refactor: loadCacheValue/saveCacheValue (RSS-Bridge#4205)

makubex2010 · Aug 8, 2024 · f358f1a · f358f1a
1 parent 2acd415
commit f358f1a
Show file tree

Hide file tree

Showing 8 changed files with 189 additions and 159 deletions.
diff --git a/bridges/BugzillaBridge.php b/bridges/BugzillaBridge.php
@@ -164,7 +164,7 @@ protected function getUser($user)
         }
 
         $cache = $this->loadCacheValue($this->instance . $user);
-        if (!is_null($cache)) {
+        if ($cache) {
             return $cache;
         }
 

diff --git a/bridges/FurAffinityBridge.php b/bridges/FurAffinityBridge.php
@@ -676,7 +676,7 @@ public function getName()
                 $name = parent::getName();
                 if ($this->getOption('aCookie') !== null) {
                     $username = $this->loadCacheValue('username');
-                    if ($username !== null) {
+                    if ($username) {
                         $name = $username . '\'s ' . parent::getName();
                     }
                 }

diff --git a/bridges/ItakuBridge.php b/bridges/ItakuBridge.php
@@ -667,7 +667,7 @@ private function getData(string $url, bool $cache = false, bool $getJSON = false
         if ($getJSON) { //get JSON object
             if ($cache) {
                 $data = $this->loadCacheValue($url);
-                if (is_null($data)) {
+                if (!$data) {
                     $data = getContents($url, $httpHeaders, $curlOptions);
                     $this->saveCacheValue($url, $data);
                 }

diff --git a/bridges/MastodonBridge.php b/bridges/MastodonBridge.php
@@ -105,7 +105,7 @@ protected function parseStatus($content)
                         break;
                     }
                     $rtUser = $this->loadCacheValue($rtContent['attributedTo']);
-                    if (!isset($rtUser)) {
+                    if (!$rtUser) {
                         // We fetch the author, since we cannot always assume the format of the URL.
                         $user = $this->fetchAP($rtContent['attributedTo']);
                         preg_match('/https?:\/\/([a-z0-9-\.]{0,})\//', $rtContent['attributedTo'], $matches);

diff --git a/bridges/PixivBridge.php b/bridges/PixivBridge.php
@@ -314,7 +314,7 @@ private function getCookie()
     {
         // checks if cookie is set, if not initialise it with the cookie from the config
         $value = $this->loadCacheValue('cookie');
-        if (!isset($value)) {
+        if (!$value) {
             $value = $this->getOption('cookie');
 
             // 30 days + 1 day to let cookie chance to renew

diff --git a/bridges/WordPressMadaraBridge.php b/bridges/WordPressMadaraBridge.php
@@ -118,7 +118,7 @@ protected function getMangaInfo($url)
     {
         $url_cache = 'TitleInfo_' . preg_replace('/[^\w]/', '.', rtrim($url, '/'));
         $cache = $this->loadCacheValue($url_cache);
-        if (isset($cache)) {
+        if ($cache) {
             return $cache;
         }