Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Review Test PR 2 #184

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/request-reviews.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ env:
jobs:
auto-request-review:
name: Add Pull Request Reviewers
if: '! github.event.pull_request.draft'
# Do not run on draft PRs and only run on PRs in the tianocore organization
if: ${{ github.event.pull_request.draft == false && github.repository_owner == 'makubacki' }}
runs-on: ubuntu-latest

permissions:
Expand All @@ -32,12 +33,12 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.x'

Expand All @@ -62,7 +63,7 @@ jobs:
WORKSPACE_PATH = os.environ['WORKSPACE_PATH']
GET_MAINTAINER_LOCAL_PATH = os.path.join(WORKSPACE_PATH, os.environ['GET_MAINTAINER_REL_PATH'])

reviewers = GitHub.get_reviewers_for_current_branch(WORKSPACE_PATH, GET_MAINTAINER_LOCAL_PATH, os.environ['TARGET_BRANCH'])
reviewers = GitHub.get_reviewers_for_current_branch(WORKSPACE_PATH, GET_MAINTAINER_LOCAL_PATH, f"origin/{os.environ['TARGET_BRANCH']}")
if not reviewers:
print("::notice title=No Reviewers Found!::No reviewers found for this PR.")
sys.exit(1)
Expand Down
2 changes: 1 addition & 1 deletion Maintainers.txt
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,4 @@ UefiCpuPkg
F: UefiCpuPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
M: Project Mu UEFI Bot <[email protected]> [uefibot]
R: Project Mu Bot <mubot@microsoft.com> [ProjectMuBot]
R: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]
2 changes: 2 additions & 0 deletions MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
//
EFI_HANDLE mDecompressHandle = NULL;

// Made a change to DxeMain

//
// DXE Core globals for Architecture Protocols
//
Expand Down
2 changes: 2 additions & 0 deletions PrmPkg/PrmPkg.dec
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
PACKAGE_GUID = 3D22F66E-9090-46CE-B260-1836070AFA5E
PACKAGE_VERSION = 0.1

# Test change in PrmPkg

[Includes]
Include

Expand Down
2 changes: 2 additions & 0 deletions UefiCpuPkg/SecMigrationPei/SecMigrationPei.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

#include "SecMigrationPei.h"

// Change in UefiCpuPkg

STATIC REPUBLISH_SEC_PPI_PPI mEdkiiRepublishSecPpiPpi = {
RepublishSecPpis
};
Expand Down
Loading