common: resolve recursively include in root manifest #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools must be present in the requirements, otherwise we have the
following errors:
```
$ make test
...
======================================================================
ERROR: repo_resource.test_check (unittest.loader._FailedTest.repo_resource.test_check)
----------------------------------------------------------------------
ImportError: Failed to import test module: repo_resource.test_check
Traceback (most recent call last):
File "/usr/local/lib/python3.12/unittest/loader.py", line 396, in _find_test_path
module = self._get_module_from_name(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/unittest/loader.py", line 339, in _get_module_from_name
__import__(name)
File "/root/repo_resource/test_check.py", line 16, in <module>
from . import check
File "/root/repo_resource/check.py", line 19, in <module>
from repo_resource import common
File "/root/repo_resource/common.py", line 27, in <module>
from repo import main as repo
File "/usr/local/lib/python3.12/site-packages/repo/main.py", line 48, in <module>
from repo.subcmds.version import Version
File "/usr/local/lib/python3.12/site-packages/repo/subcmds/__init__.py", line 18, in <module>
import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
```
Signed-off-by: Julien Masson <[email protected]>
|
This PR depends on makohoek/demo-manifests#5 |
massonju
force-pushed
the
jmasson/resolve-include-manifest
branch
from
0783d2a to
12e56e4
Compare
makohoek
reviewed
Sep 10, 2024
The root manifest may have 'include' tag, we should resolve recursively these elements and add the contents of the subsequent manifests found in the root manifest. Signed-off-by: Julien Masson <[email protected]>
massonju
force-pushed
the
jmasson/resolve-include-manifest
branch
from
12e56e4 to
877aba8
Compare
makohoek
approved these changes
Sep 10, 2024
|
@makohoek thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root manifest may have 'include' tag, we should resolve recursively these elements and add the contents of the subsequent manifests found in the root manifest.