check: Fix handling of <remove-project /> element #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makohoek
force-pushed
the
mkorpershoek/remove-project
branch
from
8003708 to
6f3aeac
Compare
|
Change in v2:
|
makohoek
force-pushed
the
mkorpershoek/remove-project
branch
from
6f3aeac to
c1c256b
Compare
|
Change in v3:
|
When `repo-resource` creates a version string (which is a full XML representation of a manifest), the `<remove-project>` tag is not taken into account. Because of this, we generate "false positives" for new Versions, which could trigger unwanted builds. For example, with manifest [1], we see that the Version string has the device/amlogic/yukawa project twice, which is wrong. Handle the <remove-project /> element to fix this. [1] https://github.com/makohoek/demo-manifests/blob/main/aosp_remove_yukawa_project.xml Fixes: #36 Fixes: c23fc0c ("Switch to getRevision code based on git ls-remote") Signed-off-by: Mattijs Korpershoek <[email protected]>
makohoek
force-pushed
the
mkorpershoek/remove-project
branch
from
c1c256b to
a99841b
Compare
|
Change in v4:
|
david-baylibre
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
repo-resourcecreates a version string (which is a full XML representation of a manifest), the<remove-project>tag is not taken into account.Because of this, we generate "false positives" for new Versions, which could trigger unwanted builds.
For example, with manifest [1], we see that the Version string has the device/amlogic/yukawa project twice, which is wrong.
Handle the element to fix this.
[1] https://github.com/makohoek/demo-manifests/blob/main/aosp_remove_yukawa_project.xml
Fixes: #36
Fixes: c23fc0c ("Switch to getRevision code based on git ls-remote")
Signed-off-by: Mattijs Korpershoek [email protected]