Support Django 5.0 and Python 3.12, drop Python 3.8 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
commented
May 8, 2024
.github/workflows/python-app.yml
Outdated
Comment on lines
18
to
29
| django_version: | ||
| - '3.2' | ||
| - '4.0' | ||
| - '4.1' | ||
| - '4.2' | ||
| - '5.0' | ||
| python_version: | ||
| - '3.7' | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| - '3.12' |
There was a problem hiding this comment.
splitting one per line will reduce the diff noise when adding/removing versions in the future
.github/workflows/python-app.yml
Outdated
| - '4.2' | ||
| - '5.0' | ||
| python_version: | ||
| - '3.7' |
There was a problem hiding this comment.
I'd also be happy to drop Python 3.7 support in this PR, since it’s EOL
| @@ -71,6 +71,7 @@ def run_tests(self): | |||
| 'context_processors': [ | |||
| 'django.contrib.auth.context_processors.auth', | |||
| 'django.contrib.messages.context_processors.messages', | |||
| 'django.template.context_processors.request', | |||
There was a problem hiding this comment.
Fixes this system check warning:
?: (admin.W411) 'django.template.context_processors.request' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin navigation sidebar.
|
Thanks for the PR, I'll merge after you remove the support of Python 3.7 then. |
adamchainz
force-pushed
the
django_5.0_python_3.12
branch
from
1a8840e
to
36de573
Compare
adamchainz
changed the title
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied most of the approach from 35d10aa. I don’t see any new warnings on Python 3.12 + Django 5.0 when running locally.