Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu-button): AT announces prefixed text twice on items #140

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix(menu-button): AT announces prefixed text twice on items #140

merged 1 commit into from
Feb 2, 2024

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Feb 1, 2024 •
edited
Loading

Fixes #139

Fixed issue by cloning the node.

  const icon = e.detail.el.querySelector(this._options.iconSelector).cloneNode(true);

@saiponnada saiponnada self-assigned this Feb 1, 2024
@saiponnada saiponnada merged commit 37c345c into master Feb 2, 2024
1 check passed
@saiponnada saiponnada deleted the menu-button-at-fix branch February 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmcburnie ianmcburnie ianmcburnie approved these changes

@ArtBlue ArtBlue Awaiting requested review from ArtBlue

@agliga agliga Awaiting requested review from agliga

@LuLaValva LuLaValva Awaiting requested review from LuLaValva

Assignees

@saiponnada saiponnada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

makeup-menu-button: SR announces value twice in list items with Icons
2 participants
@saiponnada @ianmcburnie