Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add prettier #93 #128

Merged
merged 3 commits into from
Aug 9, 2023
Merged

build: add prettier #93 #128

merged 3 commits into from
Aug 9, 2023

Conversation

ianmcburnie
Copy link
Member

@ianmcburnie ianmcburnie commented Aug 9, 2023

Three commits:

  1. Updates devDeps, this one is significant because it looks like the browser list config bumped Safari to 12 which has support for let & const. So we see those js dist files being updated appropriately.
  2. Adds the prettier dependencies and config. I decided to drop the eslint --fix portion and just let prettier handle all formatting from now on
  3. After running prettier on all files. Most of the noise is single quotes to double quotes and 4 spaces to 2. To keep noise down I also added a printWidth: 120. I may remove that later, but to be honest I like it at that setting.

Copy link
Contributor

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ianmcburnie ianmcburnie merged commit 6a41e0f into master Aug 9, 2023
1 check passed
@ianmcburnie ianmcburnie deleted the 93-imcburnie branch April 18, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants