Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waqas Ikram #2222

Open
wants to merge 27 commits into
base: example_1
Choose a base branch
from
Open

Waqas Ikram #2222

wants to merge 27 commits into from

Conversation

WaqasIkram
Copy link

Your name

Please write your full name here to make it easier to find your pull request.

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • User story 1: "I would like to see a list of dishes with prices"
  • User story 2: "I would like to be able to select some number of several available dishes"
  • User story 3: "I would like to check that the total I have been given matches the sum of the various dishes in my order"
  • User story 4: "I would like to receive a text such as "Thank you! Your order was placed and will be delivered before 18:52" after I have ordered"

README checklist

Does your README contains instructions for

  • how to install,
  • how to run,
  • and how to test your code?

Here is a pill that can help you write a great README!

neoeno and others added 27 commits February 1, 2018 12:48
Use .ruby-version instead of Gemfile for greater compatability
with different Ruby version managers
This version of scaffolint works with Rubocop 0.71.0
This challenge does not involve testing web pages
When installing 0.71.0 rubocop shows a post-install message
that warns about installing rubocop-rails as a separate gem.

This advice is distracting.
Louder credentials warning and tidy
- Use rubocop 0.79.0
- Use config file in Scaffolint GitHub repo to remove duplication
these docs are used by leaners on several courses
Encourages students to provide their name, the list of user stories they implemented and prompts them to write a good README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants