adding and displaying peeps #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siellsiell
reviewed
Apr 12, 2022
Comment on lines
+10
to
+22
| get '/peeps' do | ||
| @peeps_return = Peep.all | ||
| erb :peeps | ||
| end | ||
|
|
||
| get '/peeps/post' do | ||
| erb :post | ||
| end | ||
|
|
||
| post '/peeps/new' do | ||
| Peep.post(params[:message]) | ||
| redirect '/peeps' | ||
| end |
There was a problem hiding this comment.
Your routs are quite close to the standard RESTful routing conventions, but not quite! If you'd like to use more standard names for you routes, check out this blog post on RESTful routing: https://medium.com/@shubhangirajagrawal/the-7-restful-routes-a8e84201f206
Comment on lines
23
to
25
| get '/test' do | ||
| 'Test page' | ||
| end |
There was a problem hiding this comment.
It's always a good idea to remove test code from code you submit for code review (anywhere, not just at Makers)
Comment on lines
+17
to
+21
| if ENV['ENVIRONMENT'] == 'test' | ||
| connection = PG.connect(dbname: 'chitter_test') | ||
| else | ||
| connection = PG.connect(dbname: 'chitter') | ||
| end |
There was a problem hiding this comment.
This piece of code appears twice in this file. How might you remove this duplication?
| end | ||
| def test_data_script | ||
|
|
||
| p "setting up test chitter" |
There was a problem hiding this comment.
Same here, remove test code.
| require 'pg' | ||
| require 'peep' | ||
|
|
||
| feature 'viewing peeps' do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!