Airport Challenge Complete #2515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErlantzR
reviewed
Apr 25, 2022
lib/airport.rb
Outdated
| end | ||
|
|
||
| def check_for_storm | ||
| fail unless @current_weather != 'stormy' |
There was a problem hiding this comment.
What do you think about changing this to fail if @current_weather == 'stormy' ? It might be easy to read when this is raising the error
| plane | ||
| end | ||
|
|
||
| def def_capacity(num) |
There was a problem hiding this comment.
This method might be redundant with the attr_accessor :capacity above
| @@ -0,0 +1,38 @@ | |||
| class Airport | |||
There was a problem hiding this comment.
I think methods explain quite clearly what are they doing. I don't have problems to understand how the code works
| @@ -0,0 +1,71 @@ | |||
| require 'airport' | |||
There was a problem hiding this comment.
Tests seem clear and test appropriate features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
Jimmy Lyons
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for