Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with address comparison #943

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stonega
Copy link

@stonega stonega commented Oct 22, 2024

Link to Shortcut ticket:

What does this PR do?

Fix issue with address comparison, which caused page load error with proposal id executive page.
https://vote.makerdao.com/executive/0x70254bd530684cf4a6323f51098fa39aae6130b6

Steps for testing:

Visit https://vote.makerdao.com/address/0xa16d0708706245e5e27ac8f118776f5ed1c78d90#comments
Click View Executive

Screenshots (if relevant):

Any additional helpful information?:

Add a GIF:

Copy link

vercel bot commented Oct 22, 2024

@stonega is attempting to deploy a commit to the DUX Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

what-the-diff bot commented Oct 22, 2024

PR Summary

  • Improved Address Comparison in 'getExecutiveProposal' function
    The logic for comparing addresses in the 'getExecutiveProposal' function has been updated. Earlier, the comparison was case-sensitive, potentially causing mismatches if the same address was entered with different case usage. With this update, the comparison is now case-insensitive, offering a more robust and accurate match. Both the 'proposalId' and 'proposal.address' are converted to lowercase before the comparison, ensuring consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant