Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniswapV2LockstakeCallee renamings #44

Merged
merged 5 commits into from
Oct 23, 2024
Merged

UniswapV2LockstakeCallee renamings #44

merged 5 commits into from
Oct 23, 2024

Conversation

DaeunYoon
Copy link
Contributor

@DaeunYoon DaeunYoon commented Sep 18, 2024

Updates LockstakeClipper Callee originally developed here after the latest rebranding (and public audit contest)

Note: to run only relevant tests, one can execute forge test --match-contract=UniswapV2LockstakeCalleeTest

@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

@valiafetisov valiafetisov changed the title chore: update naming UniswapV2LockstakeCallee renamings Sep 19, 2024
Copy link
Collaborator

@valiafetisov valiafetisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ Submodule is updated to the commit found in the audit report from 27 August
  • ✅ All LSE-specific methods updated to use urn index
  • ✅ No presence of ngt or nst in the code nor comments
  • ✅ Test functions marked with Match https:// actually match linked code
  • ✅ Tests run successfully
$ forge test --match-contract=UniswapV2LockstakeCalleeTest
[⠊] Compiling...
[⠆] Compiling 10 files with Solc 0.8.25
[⠰] Solc 0.8.25 finished in 3.29s
Compiler run successful!

Ran 16 tests for src/test/UniswapV2LockstakeCallee.t.sol:UniswapV2LockstakeCalleeTest
[PASS] testCalleeTake_NoDelegate_NoStaking_MkrDai() (gas: 3495419)
[PASS] testCalleeTake_NoDelegate_NoStaking_MkrUsds() (gas: 3420635)
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyDai() (gas: 3595188)
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyUsds() (gas: 3520339)
[PASS] testCalleeTake_NoDelegate_WithStaking_MkrDai() (gas: 3535154)
[PASS] testCalleeTake_NoDelegate_WithStaking_MkrUsds() (gas: 3460326)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyDai() (gas: 3634874)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyUsds() (gas: 3560090)
[PASS] testCalleeTake_WithDelegate_NoStaking_MkrDai() (gas: 3533620)
[PASS] testCalleeTake_WithDelegate_NoStaking_MkrUsds() (gas: 3458835)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyDai() (gas: 3633319)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyUsds() (gas: 3558535)
[PASS] testCalleeTake_WithDelegate_WithStaking_MkrDai() (gas: 3573352)
[PASS] testCalleeTake_WithDelegate_WithStaking_MkrUsds() (gas: 3498545)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyDai() (gas: 3673097)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyUsds() (gas: 3628703)
Suite result: ok. 16 passed; 0 failed; 0 skipped; finished in 34.52s (72.92s CPU time)

Ran 1 test suite in 35.17s (34.52s CPU time): 16 tests passed, 0 failed, 0 skipped (16 total tests)

Based on the above, I think you can proceed with deploying the callee and then adding it to addresses.json

@DaeunYoon
Copy link
Contributor Author

The contract was deployed to 0xf68424845e4af5b771356d504965a3c9257805f3 and the address is added in addresses.json

Copy link
Collaborator

@valiafetisov valiafetisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valiafetisov valiafetisov merged commit f7162c1 into master Oct 23, 2024
1 of 3 checks passed
@valiafetisov valiafetisov deleted the update-naming branch October 23, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants