-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UniswapV2LockstakeCallee renamings #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ✅ Submodule is updated to the commit found in the audit report from 27 August
- ✅ All LSE-specific methods updated to use urn index
- ✅ No presence of
ngt
ornst
in the code nor comments - ✅ Test functions marked with
Match https://
actually match linked code - ✅ Tests run successfully
$ forge test --match-contract=UniswapV2LockstakeCalleeTest
[⠊] Compiling...
[⠆] Compiling 10 files with Solc 0.8.25
[⠰] Solc 0.8.25 finished in 3.29s
Compiler run successful!
Ran 16 tests for src/test/UniswapV2LockstakeCallee.t.sol:UniswapV2LockstakeCalleeTest
[PASS] testCalleeTake_NoDelegate_NoStaking_MkrDai() (gas: 3495419)
[PASS] testCalleeTake_NoDelegate_NoStaking_MkrUsds() (gas: 3420635)
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyDai() (gas: 3595188)
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyUsds() (gas: 3520339)
[PASS] testCalleeTake_NoDelegate_WithStaking_MkrDai() (gas: 3535154)
[PASS] testCalleeTake_NoDelegate_WithStaking_MkrUsds() (gas: 3460326)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyDai() (gas: 3634874)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyUsds() (gas: 3560090)
[PASS] testCalleeTake_WithDelegate_NoStaking_MkrDai() (gas: 3533620)
[PASS] testCalleeTake_WithDelegate_NoStaking_MkrUsds() (gas: 3458835)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyDai() (gas: 3633319)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyUsds() (gas: 3558535)
[PASS] testCalleeTake_WithDelegate_WithStaking_MkrDai() (gas: 3573352)
[PASS] testCalleeTake_WithDelegate_WithStaking_MkrUsds() (gas: 3498545)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyDai() (gas: 3673097)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyUsds() (gas: 3628703)
Suite result: ok. 16 passed; 0 failed; 0 skipped; finished in 34.52s (72.92s CPU time)
Ran 1 test suite in 35.17s (34.52s CPU time): 16 tests passed, 0 failed, 0 skipped (16 total tests)
Based on the above, I think you can proceed with deploying the callee and then adding it to addresses.json
The contract was deployed to 0xf68424845e4af5b771356d504965a3c9257805f3 and the address is added in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ✅ No code was changed after previous approval
- ✅ Code deployed to 0xf68424845e4af5b771356d504965a3c9257805f3 exactly matches UniswapV2LockstakeCallee.sol source code
- ✅ Optimization enabled with 200 runs
- ✅ Constructor arguments are correct
uniRouter02_
: 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D- Uniswap router v2 found in the official docs
daiJoin_
: 0x9759A6Ac90977b93B58547b4A71c78317f391A28MCD_JOIN_DAI
usdsJoin_
: 0x3C0f895007CA717Aa01c8693e59DF1e8C3777FEBUSDS_JOIN
mkrSky_
: 0xBDcFCA946b6CDd965f99a839e4435Bcdc1bc470BMKR_SKY
- ✅ Correct address is added to
addresses.json
- ✅ New
foundry.toml
added in this PR contains default parameters - ✅ No other unrelated files are changed via this PR
Updates LockstakeClipper Callee originally developed here after the latest rebranding (and public audit contest)
Note: to run only relevant tests, one can execute
forge test --match-contract=UniswapV2LockstakeCalleeTest