Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STALE] Feat: add batched emergency spells #7

Closed
wants to merge 27 commits into from

Conversation

amusingaxl
Copy link
Contributor

@amusingaxl amusingaxl commented Nov 21, 2024

I decided to remove the hard-coded ilks approach in favor of a more general one which allows us to specify the desired ilks in the constructor.

This approach requires some amount of hacking due to some Solidity limitations (i.e.: no support for immutable arrays, bytes32 <-> string conversion shenanigans).

While there is still some code duplication, this is significantly reduced compared to the previous approach.

Please notice that I renamed the original "multi"-ilk spells as "universal", while the term "multi" used for the new approach of passing a list in the constructor.

Due to the tight timelines here, it's best that we keep the existing naming conventions for the current contracts and simply have a different name for the new type. I'm dubbing them "Batched Emergency Spells" now.

@amusingaxl amusingaxl changed the title Feat: add multi-ilks emergency spells Feat: add batched emergency spells Nov 24, 2024
@amusingaxl amusingaxl marked this pull request as draft November 25, 2024 15:07
@amusingaxl amusingaxl closed this Nov 25, 2024
@amusingaxl amusingaxl deleted the feat/multi-ilk-spells branch November 25, 2024 15:08
@amusingaxl amusingaxl changed the title Feat: add batched emergency spells [STALE] Feat: add batched emergency spells Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant