Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwapperCalleePsm: Add note regarding dust accumulation #72

Merged
merged 2 commits into from
Nov 21, 2023
Merged

SwapperCalleePsm: Add note regarding dust accumulation #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a310b23
SwapperCalleePsm: Prevent swap amts not multiple of to18ConversionFactor
Nov 17, 2023
5be7ba4
Remove requirement on SwapperCalleePsm amt
Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/funnels/callees/SwapperCalleePsm.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ contract SwapperCalleePsm {
emit Deny(usr);
}

// Note: To avoid accumulating dust in this contract, `amt` should be a multiple of `to18ConversionFactor` when `src != gem`.
// This constraint is intentionally not enforced in this contract.
function swapCallback(address src, address /* dst */, uint256 amt, uint256 /* minOut */, address to, bytes calldata /* data */) external auth {
if (src == gem) PsmLike(psm).sellGemNoFee(to, amt);
else PsmLike(psm).buyGemNoFee (to, amt / to18ConversionFactor);
Expand Down