Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllocatorOracle: 1 WAD price #69

Merged
merged 8 commits into from
Nov 15, 2023
Merged

AllocatorOracle: 1 WAD price #69

merged 8 commits into from
Nov 15, 2023

Conversation

sunbreak1211
Copy link
Collaborator

No description provided.

@sunbreak1211 sunbreak1211 marked this pull request as ready for review November 13, 2023 20:12
@oldchili oldchili requested a review from kmbarry1 November 14, 2023 09:34
README.md Show resolved Hide resolved
@oldchili
Copy link
Collaborator

The change looks good to me in general, added 2 suggestion for comments and a general question.

Copy link
Collaborator

@oldchili oldchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/AllocatorOracle.t.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@telome telome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sunbreak1211 sunbreak1211 merged commit fdf12ec into dev Nov 15, 2023
2 checks passed
@sunbreak1211 sunbreak1211 deleted the oracle-price-1 branch November 16, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants