Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smm): uses namespace name when fetching SMM while reconciling #40

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(smm): uses namespace name when fetching SMM while reconciling #40

merged 1 commit into from
Jul 28, 2023

Conversation

bartoszmajsak
Copy link
Contributor

Previously it wrongly used ns.Namespace which is blank. That was leading to errors.

@bartoszmajsak
fix(smm): uses namespace name when fetching SMM while reconciling
9f51f3c 
Previously it wrongly used ns.Namespace which is blank leading to errors
cam-garrison
cam-garrison approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@cam-garrison cam-garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happens to the best of us

@cam-garrison cam-garrison merged commit a74eeee into main Jul 28, 2023
2 checks passed
@bartoszmajsak bartoszmajsak deleted the smm_get_fix branch July 31, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cam-garrison cam-garrison cam-garrison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszmajsak @cam-garrison