Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing resources in CRD cluster roles #1637

Open
wants to merge 1 commit into
base: maistra-2.5
Choose a base branch
from

Conversation

JulienDelacroix
Copy link

@JulienDelacroix JulienDelacroix commented Feb 20, 2024

Fix missing resources in CRD cluster roles.
Assuming these were omitted on purpose (for security reasons?), they should at least be aggregated to view.

Copy link

openshift-ci bot commented Feb 20, 2024

Hi @JulienDelacroix. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luksa
Copy link
Contributor

luksa commented Feb 27, 2024

/ok-to-test

Copy link

openshift-ci bot commented Jun 12, 2024

@JulienDelacroix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 42ced86 link true /test unit
ci/prow/lint 42ced86 link true /test lint
ci/prow/gencheck 42ced86 link true /test gencheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants