WIP: MAISTRA-2518 add conditions to federation status #23
Conversation
federation/v1/status.go
Outdated
| ReadyServiceMeshPeerCondition ConditionType = "Ready" | ||
| // Exporting indicates that the mesh is exporting services to the remote | ||
| // mesh. | ||
| ExportingExportedServiceSetCondition ConditionType = "Ready" |
There was a problem hiding this comment.
great catch, thanks!
federation/v1/status.go
Outdated
| ExportingExportedServiceSetCondition ConditionType = "Ready" | ||
| // Importing indicates that the mesh is importing services from the remote | ||
| // mesh. | ||
| ImportingImportedServiceSetCondition ConditionType = "Ready" |
federation/v1/status.go
Outdated
| @@ -0,0 +1,142 @@ | |||
| // Copyright Red Hat, Inc. | |||
There was a problem hiding this comment.
better call this file statustype.go?
There was a problem hiding this comment.
renamed to StatusConditions and statusconditions.go
federation/v1/status.go
Outdated
| // +optional | ||
| // +patchMergeKey=type | ||
| // +patchStrategy=merge | ||
| Conditions []Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,10,rep,name=conditions"` |
There was a problem hiding this comment.
is it possible to run oc wait with this? IIRC it only works with a Condition (singular) field.
There was a problem hiding this comment.
I think this is how conditions are implemented on all resources, e.g. oc wait --for=condition=Ready ...
rcernich
force-pushed
the
MAISTRA-2518
branch
2 times, most recently
from
93bccea
to
9cc9eb2
Compare
Signed-off-by: rcernich <[email protected]>
|
@rcernich: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@rcernich: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: rcernich [email protected]