-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded build actions for integration testing on pull requests #10
Conversation
|
248abfb
to
4972ff9
Compare
@maiself can you take a look at this? |
Might want to revert all the indentation changes. |
Yeah, this was the first thing I noticed when I took a quick glance thru. I'd appreciate keeping things tab indented for accessibility reasons (as well as consistency). Been a bit busy today, I'm hoping to finish things up quick so I can have a proper look, but think I'm excited to see this in. I have a few questions from the quick look I did have.
Also, big thanks for doing this! 😄 |
A previous version of the code failed to use the platform python, and it seems like you force python 3.12. I am not sure if this is better, but the match changes seem like a downgrade that didn't break anything. |
You can see the there's a manual dispatch left.
I have no preference. There's bigger fish to fry. I'm pretty sure I ran the default |
I reverted the changes to the python: TODO list for the future:
|
Ok, looked thru, I think I understand everything. There's some deprecation warnings but might be best to save that for later. If you're good with the state of it, I'm happy to merge. 👍 |
Yay, thanks! |
Testing.