Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alias name some printer objects / macro #1948

Closed
wants to merge 6 commits into from

Conversation

CF3B5
Copy link
Contributor

@CF3B5 CF3B5 commented Jul 16, 2024

Description

Alias name some printer objects / macro, so that other languages look nice :-)

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

Setting
Setting Alias name
Setting Macro alias name

Dashboard panel
Temperatures
Macro
Miscellaneous

[optional] Are there any post-deployment tasks we need to perform?

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 16, 2024
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

@meteyou
Copy link
Member

meteyou commented Jul 17, 2024

Many thanks for this PR, but unfortunately, I cannot agree with it. From the beginning of Mainsail, we have had the principle that all names in Mainsail correspond 100% to the names from the printer config, and we want to keep this behavior. I have discussed this internally with the whole crew again, and we want to keep this principle.

Can your language be used for Klipper objects with names? As an example:

[gcode_macro hotend_pos]

Can you convert the name "hotend_pos" here to your language?

If this were possible, only objects where the module name is also the object name would remain, such as [extruder], [heater_bed], etc. Then, the question is whether we can also include the possibility of translating these with i18n (optional).

Just my two cents on the general topic of "translations": My mother language is not English, but I prefer English, especially in the 3D printing business. All the terms you read on the internet when you need help or when you work on the config are in English. You can't get far without English, especially since you can't confuse terms by mistranslations.

@meteyou meteyou closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants