Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable Zoom on Mobile #1830

Closed
wants to merge 1 commit into from
Closed

Conversation

Helvio88
Copy link

The reason zooming should be disabled, is because double tapping buttons (e.g. moving an axis) causes zooming.

The reason zooming should be disabled, is because double tapping buttons (e.g. moving an axis) causes zooming.
@Helvio88 Helvio88 changed the title Disable Zoom on Mobile feat: Disable Zoom on Mobile Mar 22, 2024
@meteyou
Copy link
Member

meteyou commented Mar 22, 2024

Hey! Thx for your PR, but i cannot reproduce this issue on my phone. Which OS and browser do you use?

I think to disable scaleable ist the wrong way, because there are also some tablet users, which use the scale function.

@Helvio88
Copy link
Author

Helvio88 commented Mar 22, 2024

Hey there! I'm using Safari (Web App) on iPhone. I sometimes try to baby-step the Z axis using the buttons and the double-tapping zooms the page, which is undesirable.

Alternative solution (Global CSS):

* {
    touch-action: manipulation;
}

Docs: https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action#manipulation

@meteyou
Copy link
Member

meteyou commented Mar 24, 2024

can you please specify the selector, that it only operates for buttons?

@Helvio88
Copy link
Author

I could, it would be
button input[type="button"]

But you and I have different opinions on how wide this setting should be.

I would suggest this PR is closed and you accept the idea as a suggestion for improvement, and implement however it makes more sense to you.

Thank you for considering!

@meteyou
Copy link
Member

meteyou commented Mar 24, 2024

i just don't want to "break" anyone else's workflow, but i understand your issue and am trying to fix it as best as possible.

@meteyou
Copy link
Member

meteyou commented Nov 14, 2024

I close this PR, because of no response.

@meteyou meteyou closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants