-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reminders panel on the History page #1274
feat: Reminders panel on the History page #1274
Conversation
Thanks for your PR. I will look a little deeper during the next week. What I already noticed in the description. I would directly set the reminder to "recurring" or "one-time" when creating it. Furthermore, I would add a "snooze" button to the reminder in the notifications and create a new entry when it is done so that you have a history of how and when you performed this action. For example, you can also see how often you changed the activated carbon in the nevermore and in which calendar cycle. |
Thanks for the comment @meteyou , I will incorporate those changes over the coming week! |
6ebd1c6
to
76efd43
Compare
Hi @meteyou I've added a repeat button to the notifications, and the button is also accessible by right-clicking the reminder row on the history panel: I've also added recording of two values when a reminder is repeated: a list of total print times at which the button was pressed, as well as a list of epoch timestamps. If it's alright with you, I think the feature might be better split into two PRs - this first one, which adds basic reminders functionality, and a follow-up PR that adds a detail view accessible by left-clicking a row on in the reminders panel. The plan would be for that detail view to show a table of past snoozes, with a date + time as well as a number of print hours since the last snooze. |
Yes please! |
thx! i will test this code this week, comment if we have to "fix" something and then we can plan the next PR to extend this feature. thx for your work! |
Hey @meteyou, is there any work for me to do on this PR? |
@jeremiahvpratt hey! yes i checked it already and i startet to refactoring some print history stuff for it. i will create a PR to your branch to discuss about it. i'm only a little bit busy atm... |
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
# Conflicts: # src/store/gui/index.ts
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
This PR adds a Reminders panel, which allows users to create and manage incremental reminders based on an elapsed number of print hours since reminder creation.
This PR will fix #1129
How to use it:
What's missing:
Translations, I'm not sure what the process is for adding them.
Images:
Reminders Panel
Create Dialog
Notification
Signed off by: Jeremiah Pratt [email protected]