Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reminders panel on the History page #1274

Merged
merged 77 commits into from
Apr 28, 2024

Conversation

jeremiahvpratt
Copy link
Contributor

This PR adds a Reminders panel, which allows users to create and manage incremental reminders based on an elapsed number of print hours since reminder creation.

This PR will fix #1129

How to use it:

  1. Ensure history is enabled in your moonraker conf
  2. In the History tab, click the "+" button in the Reminders panel
  3. Add a name and print hours duration to your reminder
  4. Print for that many hours, then observe a reminder appearing in notifications.
  5. Repeat a reminder by right clicking it and selecting "repeat" - this resets the start time for the reminder to the current number of total print hours on the machine.
  6. Delete a reminder by right clicking it and selecting "delete", or selecting multiple reminders with their checkboxes and clicking the red trash icon at the top of the Reminders panel.
  7. Edit a reminder by right clicking it and selecting "edit".

What's missing:

Translations, I'm not sure what the process is for adding them.

Images:

Reminders Panel
Panel
Create Dialog
create
Notification
notification

Signed off by: Jeremiah Pratt [email protected]

@meteyou
Copy link
Member

meteyou commented Feb 19, 2023

Thanks for your PR. I will look a little deeper during the next week.

What I already noticed in the description. I would directly set the reminder to "recurring" or "one-time" when creating it. Furthermore, I would add a "snooze" button to the reminder in the notifications and create a new entry when it is done so that you have a history of how and when you performed this action. For example, you can also see how often you changed the activated carbon in the nevermore and in which calendar cycle.

@jeremiahvpratt
Copy link
Contributor Author

Thanks for the comment @meteyou , I will incorporate those changes over the coming week!

@jeremiahvpratt
Copy link
Contributor Author

Hi @meteyou I've added a repeat button to the notifications, and the button is also accessible by right-clicking the reminder row on the history panel:
image
image

I've also added recording of two values when a reminder is repeated: a list of total print times at which the button was pressed, as well as a list of epoch timestamps.

If it's alright with you, I think the feature might be better split into two PRs - this first one, which adds basic reminders functionality, and a follow-up PR that adds a detail view accessible by left-clicking a row on in the reminders panel. The plan would be for that detail view to show a table of past snoozes, with a date + time as well as a number of print hours since the last snooze.

@meteyou meteyou added this to the v2.6.0 milestone Mar 15, 2023
@matt-rendall
Copy link

Yes please!

@meteyou
Copy link
Member

meteyou commented Mar 22, 2023

thx! i will test this code this week, comment if we have to "fix" something and then we can plan the next PR to extend this feature. thx for your work!

@jeremiahvpratt
Copy link
Contributor Author

Hey @meteyou, is there any work for me to do on this PR?

@meteyou
Copy link
Member

meteyou commented Apr 25, 2023

@jeremiahvpratt hey! yes i checked it already and i startet to refactoring some print history stuff for it. i will create a PR to your branch to discuss about it. i'm only a little bit busy atm...

@meteyou meteyou mentioned this pull request May 12, 2023
@meteyou meteyou linked an issue May 12, 2023 that may be closed by this pull request
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

@meteyou meteyou mentioned this pull request Apr 23, 2024
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 5

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou meteyou merged commit 866a0c6 into mainsail-crew:develop Apr 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants