Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version field typing #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update version field typing #259

wants to merge 1 commit into from

Conversation

xiniria
Copy link

@xiniria xiniria commented Oct 2, 2023 •
edited
Loading

This PR updates the type of the version field (in RequestConfig) to only allow strings like vX (where X is a number), or vX.Y. Feel free to comment and/or edit.

Closes #258.

@xiniria
Copy link
Author

xiniria commented Nov 27, 2023

@ai-wintermute could you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "version" field is not typed
1 participant
@xiniria