Replace deprecated imghdr, switch to stable email.mime API #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imghdr will be removed in Python 3.13. email.mime.audio._whatsnd was renamed in Python 3.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming Python 3.13 will remove the built-in module
imghdr.Its mimetype-sniffing functionality was copied into
email.mime, so I switched to it inflanker/mime/message/part.py.The same file also uses
email.mime.audio._whatsnd, but since it's an internal underscore-prefixed function, it's not part of the stable API and was renamed in Python 3.11.Instead of using
email.mime.audio._whatsnd/_whatandimghdr/email.mime.image._what, I think it's safer to use the stable wrapper classesMIMEAudio,MIMEImage, even though they require a bit more work to extract the sniffed content type.If you disagree, I can switch back to using the internal function.
I tested this with Python 3.10 - please test with 2.7.
BTW, another deprecated module is
cgi, whichwebobuses, but there's an open issue about it upstream, and I'm waiting to see if they intend to release a new version.