feat: support custom branch for upscale #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2133a2d chore: remove remaining traces of network keys
These were removed from
antnode
and are no longer required.ca32ee4 chore: use different version retrieving mechanism
The versions for both
antnode
andantctl
can just come from a random VM rather than the noderegistry.
ca780ed feat: support custom branch for upscale
The upscale does not build the binaries. Instead it uses the build from the original deployment. The
binary option can be set to the same owner/branch reference as the previous deployment, and this
means Ansible will pick up the URL where the custom binary was uploaded to.
07ef86b chore: remove redundant args from
upscale
cmdThe
--desired-auditor-vm-count
and--downloaders-count
arguments do not apply any more.5ae4436 refactor: use shared mechanism for apply and plan args
The
terraform plan
andterraform apply
arguments should be identical to each other, such thatthe plan will be producing the same change set as the apply. There were different code paths for
each of them, which meant they could diverge easily.
Extract a full function for obtaining the resource value from the Terraform state. The closure was
large, so it was making the enclosing function more difficult to read. The
vm_size
variable wasrenamed because it was misleading: the function retrieves the value of any resource, not just the
size of a VM.
BREAKING CHANGE: I removed the
plan
command as part of this refactor. This command on its own justdidn't make a whole lot of sense. It makes more sense to be used with an upscale.
0d057a4 feat: obtain machine sizes from previous deploy
It's possible to launch the original deployment with values different from those in the tfvars file.
If you then try to upscale, Terraform will then want to apply the values from the tvfars file, which
could be smaller or larger.
The sizes are therefore obtained from the original deployment by inspecting the current state.