chore: always specify the quoting metric explicitly #2566
+66
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
dont_return_empty_quotess
branch
from
c33b061 to
c0d1934
Compare
RolandSherwin
changed the title
RolandSherwin
force-pushed
the
dont_return_empty_quotess
branch
from
c0d1934 to
4d9ac69
Compare
grumbach
requested changes
Jan 2, 2025
| @@ -103,7 +103,7 @@ pub enum LocalSwarmCmd { | |||
| /// Returns the quoting metrics and whether the record at `key` is already stored locally | |||
| GetLocalQuotingMetrics { | |||
| key: RecordKey, | |||
| sender: oneshot::Sender<(QuotingMetrics, bool)>, | |||
| sender: oneshot::Sender<Option<(QuotingMetrics, bool)>>, | |||
| @@ -775,7 +775,7 @@ impl Network { | |||
| pub async fn get_local_quoting_metrics( | |||
| &self, | |||
| key: RecordKey, | |||
| ) -> Result<(QuotingMetrics, bool)> { | |||
| ) -> Result<Option<(QuotingMetrics, bool)>> { | |||
There was a problem hiding this comment.
What does None mean in this case? I think Result<Option<_>> is a confusing pattern
| @@ -117,13 +117,13 @@ impl UnifiedRecordStore { | |||
| &self, | |||
| key: &RecordKey, | |||
| network_size: Option<u64>, | |||
| ) -> (QuotingMetrics, bool) { | |||
| ) -> Option<(QuotingMetrics, bool)> { | |||
Comment on lines
+621
to
+628
| Ok(None) => { | ||
| error!("Quoting metrics not found for {key:?}. This might be because we are using a ClientRecordStore??. This should not happen"); | ||
| QueryResponse::GetStoreQuote { | ||
| quote: Err(ProtocolError::GetStoreQuoteFailed), | ||
| peer_address: NetworkAddress::from_peer(self_id), | ||
| storage_proofs, | ||
| } | ||
| } |
There was a problem hiding this comment.
Would getting rid of this Option type solve the issue of the "This should not happen" error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.