-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more debug logs to client #2481
Conversation
e61ca5c
to
41929b4
Compare
6ea02cd
to
9f69dbe
Compare
autonomi/src/client/archive.rs
Outdated
debug!( | ||
"Uploaded archive {:?} to the network and the address is {:?}", | ||
archive, result | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug!( | |
"Uploaded archive {:?} to the network and the address is {:?}", | |
archive, result | |
); | |
debug!("Uploaded archive {archive:?} to the network and the address is {result:?}"); |
Tiny nitpick, but you can use the variable directly inside the {}
thingy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do the same everywhere!
autonomi/src/client/data.rs
Outdated
@@ -232,8 +233,13 @@ impl Client { | |||
|
|||
if let RecordKind::Chunk = header.kind { | |||
let chunk: Chunk = try_deserialize_record(&record)?; | |||
debug!("Chunk deserialized successfully: {:?}", chunk); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can skip the happy path, and only log the error.
409127c
to
4bc2f7f
Compare
4bc2f7f
to
5a137c3
Compare
e7877eb
to
07c7ec2
Compare
Description
Add more debug logs to support traceability across the autonomi API.
Type of Change
Please mark the types of changes made in this pull request.
Checklist
Please ensure all of the following tasks have been completed: