Auditor supplement features #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
reviewed
Jul 16, 2024
grumbach
reviewed
Jul 16, 2024
| } | ||
| } | ||
|
|
||
| if royalties.len() > (spend.spend.spent_tx.outputs.len() - 1) / 2 { |
There was a problem hiding this comment.
What if there is no change output because by chance the amount is perfect?
In this case the -1 is unnecessary. Although there is no way to know which of the outputs is the change...
There was a problem hiding this comment.
this is just for alerting suspicious spend.
with the main nano supplier is currently controlled by us, the case of no change is really rare.
so, shall not be a problem here.
grumbach
approved these changes
Jul 16, 2024
maqi
force-pushed
the
auditor_supplement_features
branch
from
e56a7ca to
caed32b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the PR #1960
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change