fix(client): perform re-attempts to clear pending transactions #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
unconfirmed_tx
branch
from
b0754fd to
e6660b4
Compare
sn_client/src/wallet.rs
Outdated
| return Err(WalletError::CouldNotSendMoney( | ||
| "Wallet has pre-unconfirmed transactions. Resend, and try again.".to_string(), | ||
| )); | ||
| if attempts > 10 { |
There was a problem hiding this comment.
Just a thought but I get the feeling we could be extracting important values like this into constants. Then we could move them out and label them so we are more aware of their importance.
https://doc.rust-lang.org/rust-by-example/custom_types/constants.html
There was a problem hiding this comment.
Yeah, you're right. Also, this functionality is used a couple of times. Will just extract it out.
JasonPaulGithub
approved these changes
Mar 28, 2024
JasonPaulGithub
added
Merge When Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary