feat: remove gossip code #1495
Merged
feat: remove gossip code #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -701,8 +601,8 @@ | |||
| custom-node-bin-org-name: maidsafe | |||
| custom-node-bin-branch-name: main | |||
|
|
|||
| # TODO: re-enable the below scripts once we have proper way to restart nodes. | |||
| # Currently on remote network (not local), the nodes do not handle restart RPC cmd well. They reuse the same | |||
| # TODO: re-enable the below scripts once we have proper way to restart nodes. | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| # TODO: re-enable the below scripts once we have proper way to restart nodes. | ||
| # Currently on remote network (not local), the nodes do not handle restart RPC cmd well. They reuse the same | ||
|
|
||
| # TODO: re-enable the below scripts once we have proper way to restart nodes. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
grumbach
reviewed
Mar 25, 2024
sn_node/src/event.rs
Outdated
| /// The raw bytes of the received message | ||
| #[debug(skip)] | ||
| msg: Bytes, | ||
| }, | ||
| /// Transfer notification message received for a public key | ||
| TransferNotif { |
There was a problem hiding this comment.
I think TransferNotif is also related to gossip
grumbach
reviewed
Mar 25, 2024
| @@ -67,26 +64,6 @@ enum Cmd { | |||
| #[command(flatten)] | |||
| peers: PeersArgs, | |||
| }, | |||
| /// Subscribe to a given Gossipsub topic | |||
There was a problem hiding this comment.
TransfersEvents { just above this is also part of gossip
grumbach
approved these changes
Mar 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
JasonPaulGithub
added
the
Pending on Upcoming Changes
|
Sorted that. Merged it in, |
BREAKING CHANGE: remove gossip as royalties will be collected via DAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove gossip as royalties will be collected via DAG
Description
reviewpad:summary