feat: test directories for acc pac with ci #1484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonPaulGithub
changed the title
JasonPaulGithub
changed the title
JasonPaulGithub
changed the title
JasonPaulGithub
changed the title
JasonPaulGithub
added
Question
2 tasks
|
Facing an issue here on writing a CI level check for the downloads. The download command requires a network address, which is given after the upload has finished. It's a different address each time it's uploaded. I need to somehow feed this into the CI-CLI. Perhaps this why the tests at the moment are ran from 'sn_client/tests/folders_api.rs'. Issue is blocked for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload and download on files and folders:
Solve for issue #1468 which covers CI tests for Acc Pac.
More creative tests can come from this, such as detecting if an empty directory has been attempted for upload, double download, sync files etc.