Misc Node Manager UX Improvements #1474
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .with(eq(ServiceInstallCtx { | ||
| args: vec
jacderida
force-pushed
the
node-manager-misc-ux
branch
2 times, most recently
from
95318bb to
b963eb7
Compare
The three `add` commands for `safenode`, `safenodemand` and `faucet` now behave in a uniform way, all supporting `--path`, `--url` and `--version` arguments. These enable a binary to be provided via a path, a URL pointing to a tar/zip containing the binary, or by a specific version number, respectively. The `safenodemand` service also now supports running as a non-root user.
Enables a port range to be specified for the metrics server ports on a series of node services. Users who run the metrics server with a specific port range can take advantage of this.
This feature was requested in community feedback. It behaves the same way as the other port arguments, in that it can be a range. Some of the `add_node` tests were changed to remove the use of a custom RPC address argument because the test case did not concern itself with customising the RPC address.
The `--service-name` and `--peer-id` arguments are changed from single use to multiple. This feature was requested in community feedback. It was only requested for one command, but a few different commands use these arguments, so all were updated to behave consistently. The integration tests were updated to make use of the arguments multiple times, which will function as a test for the change.
Another feature that was requested by the community. Add a controllable delay between each service start.
This was also requested by the community. People were attempting to use a 'v' prefix.
jacderida
force-pushed
the
node-manager-misc-ux
branch
from
3ef57e7 to
2626bdb
Compare
jacderida
changed the title
687df21 feat: uniform behaviour for all
addcommandsThe three
addcommands forsafenode,safenodemandandfaucetnow behave in a uniform way,all supporting
--path,--urland--versionarguments. These enable a binary to be provided viaa path, a URL pointing to a tar/zip containing the binary, or by a specific version number,
respectively.
The
safenodemandservice also now supports running as a non-root user.227574b feat: provide
--metrics-portarg foraddcmdEnables a port range to be specified for the metrics server ports on a series of node services.
Users who run the metrics server with a specific port range can take advantage of this.
7790105 feat: provide
--rpc-portarg foraddcmdThis feature was requested in community feedback. It behaves the same way as the other port
arguments, in that it can be a range.
Some of the
add_nodetests were changed to remove the use of a custom RPC address argument becausethe test case did not concern itself with customising the RPC address.
207fe50 feat: arguments can be used multiple times
The
--service-nameand--peer-idarguments are changed from single use to multiple. This featurewas requested in community feedback.
It was only requested for one command, but a few different commands use these arguments, so all were
updated to behave consistently.
The integration tests were updated to make use of the arguments multiple times, which will function
as a test for the change.
2736e8c feat: add
--intervalarg tostartcommandAnother feature that was requested by the community.
Add a controllable delay between each service start.
2626bdb docs: clarify version number usage
This was also requested by the community. People were attempting to use a 'v' prefix.
Description
reviewpad:summary