feat: uniform behaviour for all add commands
#1455
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .with(eq(ServiceInstallCtx { | ||
| args: vec
|
Marked do not merge but we have approvals, hope thats ok @RolandSherwin |
|
Hey @JasonPaulGithub, this PR depends on a change from |
@RolandSherwin! 👍 👍 |
JasonPaulGithub
added
the
Pending on Upcoming Changes
The three `add` commands for `safenode`, `safenodemand` and `faucet` now behave in a uniform way, all supporting `--path`, `--url` and `--version` arguments. These enable a binary to be provided via a path, a URL pointing to a tar/zip containing the binary, or by a specific version number, respectively. The `safenodemand` service also now supports running as a non-root user.
The new version of `sn-releases` uses a `Version` type rather than strings, and also renamed a trait, so the code had to be updated accordingly.
jacderida
force-pushed
the
uniform-add-cmd
branch
from
951b167 to
53e2bbd
Compare
jacderida
removed
DoNotMerge
Pending on Upcoming Changes
Creating a user for running the `safenodemand` service doesn't make as much sense because the user must have root access. We can leave it up to the user to create an account and set it up for passwordless sudo, then provide an optional `--user` argument. For now we don't have this, and just go with root.
f9998cc feat: uniform behaviour for all
addcommandsThe three
addcommands forsafenode,safenodemandandfaucetnow behave in a uniform way,all supporting
--path,--urland--versionarguments. These enable a binary to be provided viaa path, a URL pointing to a tar/zip containing the binary, or by a specific version number,
respectively.
The
safenodemandservice also now supports running as a non-root user.53e2bbd chore: upgrade
sn-releasesto new minor versionThe new version of
sn-releasesuses aVersiontype rather than strings, and also renamed atrait, so the code had to be updated accordingly.
61a4245 chore: run
safenodemandservice as rootCreating a user for running the
safenodemandservice doesn't make as much sense because the usermust have root access. We can leave it up to the user to create an account and set it up for
passwordless sudo, then provide an optional
--userargument. For now we don't have this, and justgo with root.
Description
reviewpad:summary