Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(folders): Folders and AccPacket to accept an encryption key for metadata chunks #1453

Closed

Conversation

bochaco
Copy link
Contributor

@bochaco bochaco commented Mar 14, 2024

Description

reviewpad:summary

@JasonPaulGithub JasonPaulGithub added the Small Pull request is small label Mar 14, 2024
@bochaco bochaco force-pushed the feat-folders-encrypt-metadata-chunk branch from d1516b4 to e21312b Compare March 18, 2024 11:47
@bochaco bochaco removed the Small Pull request is small label Mar 18, 2024
@bochaco bochaco force-pushed the feat-folders-encrypt-metadata-chunk branch 3 times, most recently from ec248a1 to e1b7e03 Compare March 18, 2024 12:50
@JasonPaulGithub JasonPaulGithub added the Small Pull request is small label Mar 18, 2024
@bochaco bochaco force-pushed the feat-folders-encrypt-metadata-chunk branch from e1b7e03 to 5fa06a9 Compare March 18, 2024 13:39
@bochaco bochaco removed the Small Pull request is small label Mar 18, 2024
/// TODO: currently only files and folders are supported, wallets, keys, etc., to be added later.
/// TODO: currently the provided Client's key is used both for encrypting data and signing network operations.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@JasonPaulGithub JasonPaulGithub added Small Pull request is small and removed Small Pull request is small labels Mar 18, 2024
@bochaco bochaco closed this Mar 18, 2024
@bochaco bochaco deleted the feat-folders-encrypt-metadata-chunk branch March 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants