Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(log): set log levels on the fly #1448

Merged
merged 4 commits into from
Mar 19, 2024
Merged

feat(log): set log levels on the fly #1448

merged 4 commits into from
Mar 19, 2024

Conversation

RolandSherwin
Copy link
Member

Description

reviewpad:summary

@JasonPaulGithub JasonPaulGithub added the Medium Medium sized PR label Mar 14, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 14, 2024
View reviewed changes
sn_faucet/src/main.rs
None
};
let logging_targets = vec![
// TODO: Reset to nice and clean defaults once we have a better idea of what we want

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
sn_cli/src/main.rs
None
};
let logging_targets = vec![
// TODO: Reset to nice and clean defaults once we have a better idea of what we want

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@joshuef
Copy link
Contributor

joshuef commented Mar 15, 2024

How can we test this?

Can we get a wee test that is starting logging... and then use assert_log or something (there's a crate that exists for this), that we have a) no TRACE and then b) some TRACE eg?

joshuef
joshuef requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@joshuef joshuef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment on a test

@RolandSherwin RolandSherwin force-pushed the tracing_reload branch 2 times, most recently from 9937e4e to 015e1ed Compare March 18, 2024 14:30
@joshuef joshuef added this pull request to the merge queue Mar 19, 2024
Merged via the queue into maidsafe:main with commit 421b42e Mar 19, 2024
56 checks passed
@RolandSherwin RolandSherwin mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuef joshuef joshuef approved these changes

Assignees
No one assigned
Labels
Medium Medium sized PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RolandSherwin @joshuef @JasonPaulGithub