chore(manager): use TcpListener to check free port

sn_node_manager/Cargo.toml

@@ -14,9 +14,7 @@ path="src/main.rs"
 name="safenode-manager"
 
 [features]
-default = ["quic"]
-quic = []
-tcp = []
+default = []
 
 [dependencies]
 clap = { version = "4.4.6", features = ["derive", "env"]}

sn_node_manager/src/service.rs

@@ -14,19 +14,14 @@
     ServiceInstallCtx, ServiceLabel, ServiceManager, ServiceStartCtx, ServiceStopCtx,
     ServiceUninstallCtx,
 };
-use std::net::SocketAddr;
-#[cfg(feature = "tcp")]
-use std::net::TcpListener as SocketBinder;
-#[cfg(not(feature = "tcp"))]
-use std::net::UdpSocket as SocketBinder;
-use std::path::PathBuf;
-use std::time::Duration;
-use std::{ffi::OsString, thread::sleep};
+use std::{
+    ffi::OsString,
+    net::{SocketAddr, TcpListener},
+    path::PathBuf,
+};
 use sysinfo::{Pid, System, SystemExt};
 
-// The UDP port might fail to unbind even when dropped and this can cause the safenode process to throw errors.
-const PORT_UNBINDING_DELAY: Duration = Duration::from_secs(3);
-
+/// 6
 #[derive(Debug, PartialEq)]
 pub struct ServiceConfig {
     pub data_dir_path: PathBuf,
@@ -154,12 +149,9 @@
     }
 
     fn is_port_free(&self, port: u16) -> bool {
-        let socket = SocketBinder::bind(("127.0.0.1", port));
+        let socket = TcpListener::bind(("127.0.0.1", port));
         let is_free = socket.is_ok();
         drop(socket);
-        // Sleep a little while to make sure that we've dropped the socket.
-        // Without the delay, we may face 'Port already in use' error, when trying to re-use this port.
-        sleep(PORT_UNBINDING_DELAY);
 
         is_free
     }
@@ -173,12 +165,9 @@
     fn get_available_port(&self) -> Result<u16> {
         let addr: SocketAddr = "127.0.0.1:0".parse().unwrap();
 
-        let socket = SocketBinder::bind(addr)?;
+        let socket = TcpListener::bind(addr)?;
         let port = socket.local_addr()?.port();
         drop(socket);
-        // Sleep a little while to make sure that we've dropped the socket.
-        // Without the delay, we may face 'Port already in use' error, when trying to re-use this port.
-        sleep(PORT_UNBINDING_DELAY);
 
         Ok(port)
     }