chore: include connected peers in node #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacderida
force-pushed
the
backwards-compat-test
branch
5 times, most recently
from
932daa8 to
de4a506
Compare
jacderida
changed the title
It's useful for the `status` command in the node manager to include the number of connected peers, and it may be useful at some later point to list the peers in a more detailed view.
When saving the node registry, it should create all the directories in its path.
RolandSherwin
force-pushed
the
backwards-compat-test
branch
from
de4a506 to
5a40cde
Compare
RolandSherwin
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecb7208 chore: include connected peers in node
It's useful for the
statuscommand in the node manager to include the number of connected peers,and it may be useful at some later point to list the peers in a more detailed view.
de4a506 fix: create parent directories
When saving the node registry, it should create all the directories in its path.
Description
Summary generated by Reviewpad on 18 Jan 24 13:24 UTC
This pull request includes three patches:
The first patch is a chore that adds the functionality to include the number of connected peers in the
statuscommand of the node manager. It also prepares for listing the peers in a more detailed view in the future.The second patch is a fix that ensures all parent directories are created when saving the node registry. Previously, only the final directory in the save path was created.
The third patch is a work in progress (WIP) that adds a backwards compatibility test in the CI workflow. This test is intended to ensure that the code remains compatible with previous versions.
Please review these patches and provide any necessary feedback or suggestions.