Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geo classes less linked and implement build without them #130

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Make geo classes less linked and implement build without them #130

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f0f7e5e
Create interface to avoid direct type links
Feodor0090 Sep 10, 2023
42fc38f
Move locationapi to standalone class
Feodor0090 Sep 10, 2023
6c11518
Create location api via reflection
Feodor0090 Sep 10, 2023
8fb005c
Delete location classes from package
Feodor0090 Sep 10, 2023
f85bdd6
Make CI upload no_geo jars
Feodor0090 Sep 10, 2023
ca8f77e
Forbid `LocationAPI` obfuscation
Feodor0090 Sep 10, 2023
72d8423
Fix name conflict
Feodor0090 Sep 10, 2023
26089a3
Fix proguard config
shinovon Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proguard.basecfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@
}

-keep public class * extends javax.microedition.midlet.MIDlet
-keep public class * extends mahomaps.map.ILocationAPI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С этим не согласен

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Доправь тогда как надо. По идее, надо только имя запретить трогать.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перечитал все, понял почему так надо