Resolve #8: static type checking enforced and passing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mahdiolfat
commented
Nov 23, 2023
mahdiolfat
commented
- all algorithm declarations are:
- marked as implemented or not
- annotated with static typing
- added exhaustive list of random processes from chapter 3.
- mypy'ed, locally passing all files
- ct update: verbose pytest, mypy, and ruff
- first clean set of stub files, manually added, see Create stubs and enumerate implemented vs. not implemented algorithms #9
- partially resolves Create stubs and enumerate implemented vs. not implemented algorithms #9, but direct generation from code is still needed
- all algorithm declarations are: - marked as implemented or not - annotated with static typing - added exhaustive list of random processes from chapter 3. - mypy'ed, locally passing all files - ct update: verbose pytest, mypy, and ruff - first clean set of stub files, manually added, see #9 - partially resolves #9, but direct generation from code is still needed
|
The re-open above is because I hadn't confirmed the merge the first time I tried to close this PR, so it it just closed and didn't merge. Restored and merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.