don't smooth initial delay offset

avoid detune at tap init
magnetophon · Dec 21, 2024 · 3c3aa83 · 3c3aa83
1 parent 7b7497a
commit 3c3aa83
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/lib.rs b/src/lib.rs
@@ -910,6 +910,11 @@ impl Plugin for Del2 {
                         let pan = ((f32::from(delay_tap.note) - panning_center) * panning_amount)
                             .clamp(-1.0, 1.0);
                         let (offset_l, offset_r) = Self::pan_to_haas_samples(pan, sample_rate);
+                        if meter_index + 1 > old_nr_taps {
+                            // nih_log!("reset offset for {meter_index}");
+                            delay_tap.smoothed_offset_l.reset(offset_l);
+                            delay_tap.smoothed_offset_r.reset(offset_r);
+                        }
                         delay_tap
                             .smoothed_offset_l
                             .set_target(sample_rate, offset_l);

diff --git a/todo.org b/todo.org
@@ -2,7 +2,6 @@
 
 
 * today
-** don't smooth initial delay offset -> detune at tap init
 ** crossfade highshelf to bypass when gain is low
 *** return input when gain is 0
 ** HQ mode: stereo simd, LQ mode: 4 chan simd