Code review support #266

In order to improve user experience and support new features like code-review or replies, some informations need to be added in issue / pullrequest objects and a new object pullreq-version has been created. * issue-post object: -> thread-id: id of a thread discussion -> reply-to: id of the initial post in reply to * pullreq object: -> versions: list of version object * pullreq-post object: -> thread-id: id of a thread discussion -> diff-p: describe if this post is a diff post -> resolved-by: the user who resolved this thread -> reply-to: id of the initial post in reply to -> head-ref: head SHA for this post -> commit-ref: commit SHA for this post -> base-ref: base SHA for this post -> path: file path where the diff is posted -> old-line: the line where the diff is posted before changes -> new-line: the line where the diff is posted after changes * pullreq-version: contains informations like the base and head SHA reference of a pullreq version. These informations are needed for eg. when we want to know for which version of a pullreq are diff posts. If an old forge database is detected, it will be upgraded to the new version 8. Signed-off-by: Julien Masson <[email protected]>

The discussions API provide more informations for each issue/pullreq post. We can use this API to retrieve the following informations: - Issue: thread-id, reply-to - Pullreq: thread-id, diff-p, reply-to, head/commit/base ref, path, old-line, new-line Source: https://docs.gitlab.com/ee/api/discussions.html Signed-off-by: Julien Masson <[email protected]>

The gitlab API give the possibility to fetch versions for each diff from a pullreq. Source: https://docs.gitlab.com/ee/api/merge_requests.html#get-mr-diff-versions Signed-off-by: Julien Masson <[email protected]>

With PullRequest and PullRequestReviewThread graphql object, we can set some fields of issue, pull-request and version objects. In order to access to some elements of PullRequestReviewThread, we need to toggle "Multi-Line Comments Preview": https://developer.github.com/v4/previews/#multi-line-comments-preview Source: https://developer.github.com/v4/object/pullrequest/ https://developer.github.com/v4/object/pullrequestreviewthread/ Signed-off-by: Julien Masson <[email protected]>

In the pullreq view, the version sections are now displayed instead of commits. These sections contains commits and diff changes for each version. The number of comments per commits or diff changes are also displayed. Example: Diff changes --> Latest Version: (6 comments) Commits --> 3634ab3 commit-A (4 comments) Commits --> 0df0d75 commit-B (1 comments) Commits --> 441de84 commit-C (1 comments) Press RET on "Diff changes" will show the diff of all the commits. Press RET on "Commits" will show the corresponding commit. Signed-off-by: Julien Masson <[email protected]>

In the topic view the diff posts should not be displayed. We only display posts/replies related to the topic conversation. Signed-off-by: Julien Masson <[email protected]>

The replies are now inserted in the correct thread section and are indented. Signed-off-by: Julien Masson <[email protected]>

After RET in version section, the diff posts are now displayed in the magit diff buffer. Signed-off-by: Julien Masson <[email protected]>

Originally when pressing RET in a hunk section, it opens the file at the right position in the buffer. With a magit-diff buffer which contains diff posts, this feature is broken, the position in the file buffer is not correct. This patch handle this case when the magit-diff buffer contains diff posts. Signed-off-by: Julien Masson <[email protected]>

This new command allow the user to create a diff post from a magit-diff buffer. The diff buffer has to be generated from a pullreq. This command is only supported by Gitlab and Github. Signed-off-by: Julien Masson <[email protected]>

This new command allow the user to reply to any post. This command is only supported by Gitlab and Github. Signed-off-by: Julien Masson <[email protected]>

With a gitlab repo, it's now possible to pull a single topic. It can be either a pullreq or issue topic. Signed-off-by: Julien Masson <[email protected]>

In the code all the "comment" are treated as a post object. A post object can be found in a pull-request or an issue for eg. To avoid confusion it makes more sense to use "post" instead of "comment" in the function name when handling post object. Also forge-comment-at-point function has been removed since it's not used. Signed-off-by: Julien Masson <[email protected]>

Signed-off-by: Julien Masson <[email protected]>

When editing a diff post, the URL must be the following format: /repos/:owner/:repo/pulls/comments/:comment_id Source: https://developer.github.com/v3/pulls/comments/#edit-a-comment Signed-off-by: Julien Masson <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code review support #266

Code review support #266

Commits on Apr 5, 2021