Skip to content

Commit

Permalink
Remove emacsql-log-buffer accessor for good
Browse files Browse the repository at this point in the history
Deprecating the `emacsql-log-buffer' accessor wasn't graceful to begin
with ([1: 3ec2c96], [2: f58cdd1]) and now (#119) we have learned that
it also causes issues.  Instead remove it outright and be done with it.

1: 2024-01-20 3ec2c96
   emacsql-log-buffer: Deprecate this accessor for log-buffer slot

2: 2024-01-21 f58cdd1
   emacsql-log-buffer: Also deprecate as generalized variable

Closes #119.
  • Loading branch information
tarsius committed Jan 24, 2024
1 parent eb69177 commit 5aba772
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions emacsql.el
Original file line number Diff line number Diff line change
Expand Up @@ -103,18 +103,6 @@ may return `process', `user-ptr' or `sqlite' for this value.")
"A connection to a SQL database."
:abstract t)

(cl-defmethod (setf emacsql-log-buffer) (value (obj emacsql-connection))
(oset obj log-buffer value))
(make-obsolete-generalized-variable 'emacsql-log-buffer
"use (oset obj log-buffer val) instead."
"EmacsSQL 4.0.0")
(with-suppressed-warnings ((obsolete emacsql-log-buffer))
(cl-defmethod emacsql-log-buffer ((obj emacsql-connection)) "\
Retrieve the slot `log-buffer' from an object of class `emacsql-connection'."
(oref obj log-buffer)))
(make-obsolete 'emacsql-log-buffer "use (oref obj log-buffer) instead."
"EmacSQL 4.0.0")

(cl-defgeneric emacsql-close (connection)
"Close CONNECTION and free all resources.")

Expand Down

0 comments on commit 5aba772

Please sign in to comment.