Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi magist3r,
I'm not sure when or if I'll work on this more, so I thought I better submit a pull request.
I haven't tested it built statically yet. But I don't know when I'll get back to working on this project. Hope this commit helps!
http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5
I fixed the headers by running this perl script from the source folder directory of QtWeb:
The first dozen or so I did by hand.
Since QtFtp and QtHttp are now add-on plugins instead of standard elements I built those:
http://qt-project.org/forums/viewthread/24466/#121595
Most of the changes were pretty straightforward. The differences in the CookieJar and History class with their use of
reset()
on theirQAbstractItemModel
s could use a second set of eyes, because they recommend wrapping the changes withbeginResetModel()
andendResetModel()
. I did it over a few minutes with really digging into the mechanics of those classes.http://qt-project.org/doc/qt-5/qabstractitemmodel-compat.html#reset
Also the standardPaths changed to a
QStringList
, and for now I just put.first()
. Later error checking could be added in the bizarre case that an OS doesn't have any standardPaths available.There are still a number of warnings, mostly
and one
Below are the screenshots of all the warnings (83 of them) thrown by a release build after a build clean.