Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fix issue #708

Merged
merged 2 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions packages/mysql/src/configs/mysql.config.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
import {injectable} from "tsyringe";
import {ServiceDefinitionTagEnum, tag} from "@pristine-ts/common";

@tag(ServiceDefinitionTagEnum.MysqlConfig)
@injectable()
export class MysqlConfig {
constructor(
public readonly uniqueKeyname: string,
public readonly host: string,
public readonly port: number,
public readonly user: string,
public readonly password: string,
public readonly connectionLimit: number,
public readonly debug: boolean,
public readonly database: string,
) {
}
export interface MysqlConfig {
uniqueKeyname: string,
host: string,
port: number,
user: string,
password: string,
connectionLimit: number,
debug: boolean,
database: string,
}
11 changes: 10 additions & 1 deletion packages/mysql/src/mysql.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,16 @@ export const MysqlModule: ModuleInterface = {
providerRegistrations: [
{
token: ServiceDefinitionTagEnum.MysqlConfig,
useValue: new MysqlConfig("__default__", "", 0, "", "", 0, false, "")
useValue: {
uniqueKeyname: "__default__",
host: "",
port: 0,
user: "",
password: "",
connectionLimit: 0,
debug: false,
database: "",
}
}
]
};
2 changes: 1 addition & 1 deletion packages/telemetry/src/managers/tracing.manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class TracingManager implements TracingManagerInterface {
if (parentSpans) {
if (parentSpans.length > 1) {
if (!parentId) {
this.loghandler.error("Error finding the parent span, there are multiple spans with that keyname and no id is provided.", {parentKeyname});
//this.loghandler.error("Error finding the parent span, there are multiple spans with that keyname and no id is provided.", {parentKeyname});
} else {
parentSpan = parentSpans.find(span => span.id === parentId) ?? parentSpan;
}
Expand Down
Loading