-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipboard as an optional feature #157 #259
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 37.39% 37.51% +0.12%
==========================================
Files 18 18
Lines 3166 3153 -13
==========================================
- Hits 1184 1183 -1
+ Misses 1982 1970 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pull request in my life so bear with me here! :D
Congratulations! :)
We can definitely get this in. It already looks pretty good. I gave you a little feedback on what could be improved.
Ok, thank you for the suggestions. You are right about the whitespace; my bad 😄. |
Yes, you need to make it optional. But what's the issue here? While it is unfortunate that line got changed in between, nothing functional changed, just the formatting. I will probably squash all your commits, so don't worry how it looks like. For the future though I recommend rebasing the PR instead of merging main into your branch. That usually doesn't lead to a great time. |
Thanks for working on this 😄 |
First pull request in my life so bear with me here! :D
I have added a new feature "clipboard" that when not present disables the
arboard
crate so wormhole can compile on Android and headless machines as requested in #157. I also moved the creation of the clipboard object right before the actual use of it to make it easier to conditionally enable/disable without messing with like 10 function calls. I have also changed theforward serve
wormhole code message to reflect the clipboard option so the user knows if it got copied. Feedback would be appreciated.