Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard as an optional feature #157 #259

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

kernelPanic0x
Copy link
Contributor

First pull request in my life so bear with me here! :D
I have added a new feature "clipboard" that when not present disables the arboard crate so wormhole can compile on Android and headless machines as requested in #157. I also moved the creation of the clipboard object right before the actual use of it to make it easier to conditionally enable/disable without messing with like 10 function calls. I have also changed the forward serve wormhole code message to reflect the clipboard option so the user knows if it got copied. Feedback would be appreciated.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.51%. Comparing base (8d43e65) to head (d99d120).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/main.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   37.39%   37.51%   +0.12%     
==========================================
  Files          18       18              
  Lines        3166     3153      -13     
==========================================
- Hits         1184     1183       -1     
+ Misses       1982     1970      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@felinira felinira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pull request in my life so bear with me here! :D

Congratulations! :)

We can definitely get this in. It already looks pretty good. I gave you a little feedback on what could be improved.

cli/Cargo.toml Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
@kernelPanic0x
Copy link
Contributor Author

Ok, thank you for the suggestions. You are right about the whitespace; my bad 😄.
But I can't merge the current state into my fork because I need the optional = true flag for the arboard crate. Otherwise, I can't make it conditional, or can I?

@felinira
Copy link
Collaborator

But I can't merge the current state into my fork because I need the optional = true flag for the arboard crate. Otherwise, I can't make it conditional, or can I?

Yes, you need to make it optional. But what's the issue here? While it is unfortunate that line got changed in between, nothing functional changed, just the formatting.

I will probably squash all your commits, so don't worry how it looks like. For the future though I recommend rebasing the PR instead of merging main into your branch. That usually doesn't lead to a great time.

@felinira felinira merged commit 040e422 into magic-wormhole:main Sep 12, 2024
20 checks passed
@felinira
Copy link
Collaborator

Thanks for working on this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants