Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Add docs and deprecation notices #240

Merged
merged 18 commits into from
Jul 17, 2024
Merged

Conversation

felinira
Copy link
Collaborator

@felinira felinira commented Jul 13, 2024

Keep the old methods around as an alias to not break too many things from one release to the next.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 23.17073% with 252 lines in your changes missing coverage. Please review.

Project coverage is 38.15%. Comparing base (5b2161d) to head (82f0647).

Files Patch % Lines
src/transfer/offer.rs 24.47% 145 Missing ⚠️
src/transfer.rs 3.22% 60 Missing ⚠️
cli/src/main.rs 0.00% 22 Missing ⚠️
src/core.rs 33.33% 12 Missing ⚠️
src/transfer/v1.rs 60.71% 11 Missing ⚠️
src/transit.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   38.55%   38.15%   -0.40%     
==========================================
  Files          17       18       +1     
  Lines        3081     3163      +82     
==========================================
+ Hits         1188     1207      +19     
- Misses       1893     1956      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch 4 times, most recently from b136ed3 to 13bee82 Compare July 13, 2024 02:03
@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch from 13bee82 to 793acef Compare July 13, 2024 02:09
@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch from 5593a22 to 4b9eb8b Compare July 13, 2024 16:35
@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch from 45c069e to 0c9ed6a Compare July 15, 2024 15:54
@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch from 0c9ed6a to 4b2e970 Compare July 15, 2024 16:14
@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch from 4464509 to eb2df30 Compare July 15, 2024 20:23
@felinira felinira force-pushed the wip/fina/transfer-v2-cleanup branch from 50b391c to d9cc321 Compare July 15, 2024 21:42
@felinira felinira changed the title transfer: Soft-deprecrate old send and receive methods code: Add docs and deprecation notices Jul 15, 2024
@felinira felinira merged commit f52138b into master Jul 17, 2024
16 of 18 checks passed
@felinira felinira deleted the wip/fina/transfer-v2-cleanup branch July 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant