remove Cow

src/core.rs

@@ -478,13 +478,13 @@ impl<S: Into<String>> From<S> for EitherSide {
 
 #[derive(PartialEq, Eq, Clone, Debug, Deserialize, Serialize, derive_more::Display)]
 #[display(fmt = "{}-{}", "&*_0", "&*_1")]
-pub struct ClientVersion(pub Cow<'static, str>, pub Cow<'static, str>);
+pub struct ClientVersion(pub String, pub String);
 
 impl ClientVersion {
-    pub fn new(implementation: Cow<'static, str>, version: Cow<'static, str>) -> Self {
+    pub fn new(implementation: &str, version: &str) -> Self {
         ClientVersion {
-            0: implementation,
-            1: version,
+            0: implementation.to_string(),
+            1: version.to_string(),
         }
     }
 }

src/core/server_messages.rs

@@ -1,6 +1,6 @@
 use super::{AppID, ClientVersion, Mailbox, Mood, MySide, Nameplate, Phase, TheirSide};
 use serde_derive::{Deserialize, Serialize};
-use std::{borrow::Cow, collections::HashMap};
+use std::{collections::HashMap};
 
 /// Special encoding for the `nameplates` message
 #[derive(Serialize, Deserialize, Debug, PartialEq)]
@@ -187,8 +187,8 @@ impl OutboundMessage {
     pub fn bind(appid: AppID, side: MySide) -> Self {
         let client_version_string: &str = env!("CARGO_PKG_VERSION");
         let client_version = ClientVersion::new(
-            Cow::Borrowed(CLIENT_NAME),
-            Cow::Borrowed(client_version_string),
+            CLIENT_NAME,
+            client_version_string,
         );
         OutboundMessage::Bind {
             appid,
@@ -290,7 +290,7 @@ mod test {
 
     #[test]
     fn test_client_version_string_rep() {
-        let client_version = ClientVersion::new(Cow::Borrowed("foo"), Cow::Borrowed("1.0.2"));
+        let client_version = ClientVersion::new("foo", "1.0.2");
 
         assert_eq!(client_version.to_string(), "foo-1.0.2")
     }