予約確定機能 #18
Closed
予約確定機能 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAK848
requested changes
Sep 22, 2023
entity/event.go
Outdated
| UnitSeconds int `json:"unitSeconds"` | ||
| Units []EventTimeUnit `json:"units"` | ||
| UserAnswers []UserEventAnswer `json:"userAnswers"` | ||
| UserAnswersCount int `json:"userAnswersCount"` |
There was a problem hiding this comment.
UserAnswersCountはEventのEntityとしては不要
controller/event.go
Outdated
| @@ -120,6 +120,13 @@ func (ec *eventController) CreateAnswer(c echo.Context) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| // すべての回答が集まったら，確定メールを送る | |||
| if event.UserAnswersCount == event.NumberOfParticipants { | |||
There was a problem hiding this comment.
現状DBに保存していないので，右辺が揮発してしまいます…
あとそもそも送信するかどうかをチェックしていないので，送信設定していないのに送信する事故が起こりそう
あとは，
あ，ちょっと嘘ついた
controllerでした設計的には，
usecaseのCreateUserAnswer
で，最後にcount処理をrepositoryに用意・取得してそれを呼び，そこから送るのが良いかな
と訂正したように，controllerはデータの変換処理に留めてロジックは書かないでほしいです…！（usecaseに！）
There was a problem hiding this comment.
DBに保存するにはどこをどういじればいいですか？
There was a problem hiding this comment.
ざっくり言うと
- migrationファイル追加
make generate- Repository追加
です！
Comment on lines
+30
to
+32
| NotifyByEmail bool `json:"notifyByEmail"` | ||
| NumberOfParticipants int `json:"numberOfParticipants"` | ||
| ConfirmationEmail string `json:"confirmationEmail"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更の概要
#12
なぜこの変更をするのか
参加者全員が回答したら代表者に通知を送るため
やったこと
entity/event.go
Event,EventRequest構造体の拡張
controller/event.go
CreateAnswer関数にSendMail関数へ行く処理の追加
usecase/event.go
CreateUserAnswer関数にユーザーの回答数を数えるFetchUserAnswerCount関数へ行く処理の追加
repository/event.go
FetchUserAnswerCount関数の追加
課題
ブランチが違うことによるcontroller/event.goの「SendMail関数がありません」エラー