Email logs doesn't work in developer mode. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I replicated it too. The code needs to take into account whether development mode is activated |
|
@nghiatt01 @Linhnv1902 Hi, have you looked at this error yet? When do you plan to add a fix? |
|
Agree, this is a requirement for development. Logging should log if the log setting is turned on / off. Logging is crucial for development and testing. This needs an urgent fix. |
|
The issue is still there in the latest version. When you switch to developer mode, it should not send out the emails but should add them to logs. But it doesn't do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the developer mode the email logs doesn't work. Previous versions worked correctly.