-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #7 from mageplaza/2.3-develop
Clean code
- Loading branch information
Showing
17 changed files
with
779 additions
and
779 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Technical issue with the extension | ||
| labels: 'Issue' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Preconditions (*) | ||
| <!--- | ||
| Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Steps to reproduce (*) | ||
| <!--- | ||
| Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Expected result (*) | ||
| <!--- Tell us what do you expect to happen. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
|
|
||
| ### Actual result (*) | ||
| <!--- Tell us what happened instead. Include error messages and issues. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
| --- | ||
| name: Bug report | ||
| about: Technical issue with the extension | ||
| labels: 'Issue' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Preconditions (*) | ||
| <!--- | ||
| Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Steps to reproduce (*) | ||
| <!--- | ||
| Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Expected result (*) | ||
| <!--- Tell us what do you expect to happen. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
|
|
||
| ### Actual result (*) | ||
| <!--- Tell us what happened instead. Include error messages and issues. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| --- | ||
| name: Developer experience issue | ||
| about: Issues related to customization, extensibility, modularity | ||
| labels: 'Experience' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Summary (*) | ||
| <!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. --> | ||
|
|
||
| ### Examples (*) | ||
| <!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. --> | ||
|
|
||
| ### Proposed solution | ||
| <!--- Suggest your potential solutions for this issue. --> | ||
| --- | ||
| name: Developer experience issue | ||
| about: Issues related to customization, extensibility, modularity | ||
| labels: 'Experience' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Summary (*) | ||
| <!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. --> | ||
|
|
||
| ### Examples (*) | ||
| <!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. --> | ||
|
|
||
| ### Proposed solution | ||
| <!--- Suggest your potential solutions for this issue. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Request feature for development | ||
| labels: 'Feature Request' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Description (*) | ||
| <!--- Describe the feature you would like to add. --> | ||
|
|
||
| ### Expected behavior (*) | ||
| <!--- What is the expected behavior of this feature? How is it going to work? --> | ||
|
|
||
| ### Benefits | ||
| <!--- How do you think this feature would improve the extension? --> | ||
|
|
||
| ### Additional information | ||
| <!--- What other information can you provide about the desired feature? --> | ||
| --- | ||
| name: Feature request | ||
| about: Request feature for development | ||
| labels: 'Feature Request' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Description (*) | ||
| <!--- Describe the feature you would like to add. --> | ||
|
|
||
| ### Expected behavior (*) | ||
| <!--- What is the expected behavior of this feature? How is it going to work? --> | ||
|
|
||
| ### Benefits | ||
| <!--- How do you think this feature would improve the extension? --> | ||
|
|
||
| ### Additional information | ||
| <!--- What other information can you provide about the desired feature? --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| <!--- Provide a general summary of the Pull Request in the Title above --> | ||
|
|
||
| ### Description | ||
| <!--- Provide a description of the changes proposed in the pull request --> | ||
|
|
||
| ### Fixed Issues (if relevant) | ||
| <!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant --> | ||
| 1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title | ||
| 2. ... | ||
|
|
||
| ### Manual testing scenarios | ||
| <!--- Provide a set of unambiguous steps to test the proposed code change --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Contribution checklist | ||
| - [ ] Pull request has a meaningful description of its purpose | ||
| - [ ] All commits are accompanied by meaningful commit messages | ||
| - [ ] All new or changed code is covered with unit/integration tests (if applicable) | ||
| <!--- Provide a general summary of the Pull Request in the Title above --> | ||
|
|
||
| ### Description | ||
| <!--- Provide a description of the changes proposed in the pull request --> | ||
|
|
||
| ### Fixed Issues (if relevant) | ||
| <!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant --> | ||
| 1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title | ||
| 2. ... | ||
|
|
||
| ### Manual testing scenarios | ||
| <!--- Provide a set of unambiguous steps to test the proposed code change --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Contribution checklist | ||
| - [ ] Pull request has a meaningful description of its purpose | ||
| - [ ] All commits are accompanied by meaningful commit messages | ||
| - [ ] All new or changed code is covered with unit/integration tests (if applicable) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| # Configuration for probot-no-response - https://github.com/probot/no-response | ||
|
|
||
| # Number of days of inactivity before an Issue is closed for lack of response | ||
| daysUntilClose: 7 | ||
| # Label requiring a response | ||
| responseRequiredLabel: waiting-customer-response | ||
| # Comment to post when closing an Issue for lack of response. Set to `false` to disable | ||
| closeComment: > | ||
| This issue has been automatically closed because there has been no response | ||
| to our request for more information from the original author. With only the | ||
| information that is currently in the issue, we don't have enough information | ||
| to take action. Please reach out if you have or find the answers we need so | ||
| that we can investigate further. | ||
| # Configuration for probot-no-response - https://github.com/probot/no-response | ||
|
|
||
| # Number of days of inactivity before an Issue is closed for lack of response | ||
| daysUntilClose: 7 | ||
| # Label requiring a response | ||
| responseRequiredLabel: waiting-customer-response | ||
| # Comment to post when closing an Issue for lack of response. Set to `false` to disable | ||
| closeComment: > | ||
| This issue has been automatically closed because there has been no response | ||
| to our request for more information from the original author. With only the | ||
| information that is currently in the issue, we don't have enough information | ||
| to take action. Please reach out if you have or find the answers we need so | ||
| that we can investigate further. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,33 @@ | ||
| Copyright © 2016-present Mageplaza Co. Ltd. | ||
|
|
||
| This License is entered by Mageplaza to govern the usage or redistribution of Mageplaza software. This is a legal agreement between you (either an individual or a single entity) and Mageplaza for Mageplaza software product(s) which may include extensions, templates and services. | ||
|
|
||
| By purchasing, installing, or otherwise using Mageplaza products, you acknowledge that you have read this License and agree to be bound by the terms of this Agreement. If you do not agree to the terms of this License, do not install or use Mageplaza products. | ||
|
|
||
| The Agreement becomes effective at the moment when you acquire software from our site or receive it through email or on data medium or by any other means. Mageplaza reserves the right to make reasonable changes to the terms of this license agreement and impose its clauses at any given time. | ||
|
|
||
| 1. GRANT OF LICENSE: By purchasing a product of Mageplaza: | ||
|
|
||
| 1. Customer will receive source code open 100%. | ||
|
|
||
| 2. Customer will obtain a License Certificate which will remain valid until the Customer stops using the Product or until Mageplaza terminates this License because of Customer’s failure to comply with any of its Terms and Conditions. Each License Certificate includes a license serial which is valid for one live Magento installation only and unlimited test Magento installations. | ||
|
|
||
| 3. You are allowed to customize our products to fit with your using purpose. | ||
|
|
||
| 4. DESCRIPTION OF OTHER RIGHTS AND LIMITATIONS | ||
|
|
||
| 5. Installation and Use | ||
|
|
||
| 6. For each new Software installation, you are obliged to purchase a separate License. You are not permitted to use any part of the code in whole or part in any other software or product or website. You are legally bound to preserve the copyright information intact including the text/link at bottom. | ||
|
|
||
| 2. Distribution: You are not allowed to distribute Mageplaza software to third parties. Any distribution without our permission, including non commercial distribution is considered as violation of this Agreement and entails liability, according to the current law. You may not place the Software onto a server that allows access to the Software via a public network or the Internet for distribution purposes. | ||
|
|
||
| 3. Rental: You may not give, sell, sub-license, rent, lease or lend any portion of the Software to anyone. | ||
|
|
||
| 4. Compliance with Applicable Laws: You must comply with all applicable laws regarding use of software products. Mageplaza software and a portion of it are protected by copyright laws and international copyright treaties, as well as other intellectual property laws and treaties. Accordingly, customer is required to treat the software like any other copyrighted material. Any activity violating copyright law will be prosecuted according to the current law. We retain the right to revoke the license of any user holding an invalid license. | ||
|
|
||
| 5. TERMINATION: Without prejudice to any other rights, Mageplaza may terminate this License at any time if you fail to comply with the terms and conditions of this License. In such event, it constitutes a breach of the agreement, and your license to use the program is revoked and you must destroy all copies of Mageplaza products in your possession. After being notified of termination of your license, if you continue to use Mageplaza software, you hereby agree to accept an injunction to prevent you from its further use and to pay all costs (including but not limited to reasonable attorney fees) to enforce our revocation of your license and any damages suffered by us because of your misuse of the Software. We are not bound to return you the amount spent for purchase of the Software for the termination of this License. | ||
|
|
||
| 6. LIMITATION OF LIABILITY: In no event shall Mageplaza be liable for any damages (including, without limitation, lost profits, business interruption, or lost information) rising out of ‘Authorized Users’ use of or inability to use the Mageplaza products, even if Mageplaza has been advised of the possibility of such damages. In no event will Mageplaza be liable for prosecution arising from use of the Software against law or for any illegal use. | ||
|
|
||
| Copyright © 2016-present Mageplaza Co. Ltd. | ||
| This License is entered by Mageplaza to govern the usage or redistribution of Mageplaza software. This is a legal agreement between you (either an individual or a single entity) and Mageplaza for Mageplaza software product(s) which may include extensions, templates and services. | ||
| By purchasing, installing, or otherwise using Mageplaza products, you acknowledge that you have read this License and agree to be bound by the terms of this Agreement. If you do not agree to the terms of this License, do not install or use Mageplaza products. | ||
| The Agreement becomes effective at the moment when you acquire software from our site or receive it through email or on data medium or by any other means. Mageplaza reserves the right to make reasonable changes to the terms of this license agreement and impose its clauses at any given time. | ||
| 1. GRANT OF LICENSE: By purchasing a product of Mageplaza: | ||
| 1. Customer will receive source code open 100%. | ||
| 2. Customer will obtain a License Certificate which will remain valid until the Customer stops using the Product or until Mageplaza terminates this License because of Customer’s failure to comply with any of its Terms and Conditions. Each License Certificate includes a license serial which is valid for one live Magento installation only and unlimited test Magento installations. | ||
| 3. You are allowed to customize our products to fit with your using purpose. | ||
| 4. DESCRIPTION OF OTHER RIGHTS AND LIMITATIONS | ||
| 5. Installation and Use | ||
| 6. For each new Software installation, you are obliged to purchase a separate License. You are not permitted to use any part of the code in whole or part in any other software or product or website. You are legally bound to preserve the copyright information intact including the text/link at bottom. | ||
| 2. Distribution: You are not allowed to distribute Mageplaza software to third parties. Any distribution without our permission, including non commercial distribution is considered as violation of this Agreement and entails liability, according to the current law. You may not place the Software onto a server that allows access to the Software via a public network or the Internet for distribution purposes. | ||
| 3. Rental: You may not give, sell, sub-license, rent, lease or lend any portion of the Software to anyone. | ||
| 4. Compliance with Applicable Laws: You must comply with all applicable laws regarding use of software products. Mageplaza software and a portion of it are protected by copyright laws and international copyright treaties, as well as other intellectual property laws and treaties. Accordingly, customer is required to treat the software like any other copyrighted material. Any activity violating copyright law will be prosecuted according to the current law. We retain the right to revoke the license of any user holding an invalid license. | ||
| 5. TERMINATION: Without prejudice to any other rights, Mageplaza may terminate this License at any time if you fail to comply with the terms and conditions of this License. In such event, it constitutes a breach of the agreement, and your license to use the program is revoked and you must destroy all copies of Mageplaza products in your possession. After being notified of termination of your license, if you continue to use Mageplaza software, you hereby agree to accept an injunction to prevent you from its further use and to pay all costs (including but not limited to reasonable attorney fees) to enforce our revocation of your license and any damages suffered by us because of your misuse of the Software. We are not bound to return you the amount spent for purchase of the Software for the termination of this License. | ||
| 6. LIMITATION OF LIABILITY: In no event shall Mageplaza be liable for any damages (including, without limitation, lost profits, business interruption, or lost information) rising out of ‘Authorized Users’ use of or inability to use the Mageplaza products, even if Mageplaza has been advised of the possibility of such damages. In no event will Mageplaza be liable for prosecution arising from use of the Software against law or for any illegal use. | ||
| The latest License: https://www.mageplaza.com/LICENSE.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,54 @@ | ||
| ## Documentation | ||
|
|
||
| - Installation guide: https://www.mageplaza.com/install-magento-2-extension/#solution-1-ready-to-paste | ||
| - User Guide: https://docs.mageplaza.com/facebook-plugin/ | ||
| - Product page: https://www.mageplaza.com/magento-2-facebook-plugin/ | ||
| - FAQs: https://www.mageplaza.com/faqs/ | ||
| - Get Support: https://mageplaza.freshdesk.com/ or [email protected] | ||
| - Changelog: https://www.mageplaza.com/releases/facebook-plugin/ | ||
| - License agreement: https://www.mageplaza.com/LICENSE.txt | ||
|
|
||
| ## How to install | ||
|
|
||
| ### Install ready-to-paste package (Recommended) | ||
|
|
||
| - Installation guide: https://www.mageplaza.com/install-magento-2-extension/ | ||
|
|
||
| ## How to upgrade | ||
|
|
||
| 1. Backup | ||
|
|
||
| Backup your Magento code, database before upgrading. | ||
|
|
||
| 2. Remove FacebookPlugin folder | ||
|
|
||
| In case of customization, you should backup the customized files and modify in newer version. | ||
| Now you remove `app/code/Mageplaza/FacebookPlugin` folder. In this step, you can copy override FacebookPlugin folder but this may cause of compilation issue. That why you should remove it. | ||
|
|
||
| 3. Upload new version | ||
| Upload this package to Magento root directory | ||
|
|
||
| 4. Run command line: | ||
|
|
||
| ``` | ||
| php bin/magento setup:upgrade | ||
| php bin/magento setup:static-content:deploy | ||
| ``` | ||
|
|
||
|
|
||
| ## FAQs | ||
|
|
||
|
|
||
| #### Q: I got error: `Mageplaza_Core has been already defined` | ||
| A: Read solution: https://github.com/mageplaza/module-core/issues/3 | ||
|
|
||
|
|
||
| #### Q: My site is down | ||
| A: Please follow this guide: https://www.mageplaza.com/blog/magento-site-down.html | ||
|
|
||
|
|
||
| ## Support | ||
|
|
||
| - FAQs: https://www.mageplaza.com/faqs/ | ||
| - https://mageplaza.freshdesk.com/ | ||
| - [email protected] | ||
| ## Documentation | ||
|
|
||
| - Installation guide: https://www.mageplaza.com/install-magento-2-extension/#solution-1-ready-to-paste | ||
| - User Guide: https://docs.mageplaza.com/facebook-plugin/ | ||
| - Product page: https://www.mageplaza.com/magento-2-facebook-plugin/ | ||
| - FAQs: https://www.mageplaza.com/faqs/ | ||
| - Get Support: https://mageplaza.freshdesk.com/ or [email protected] | ||
| - Changelog: https://www.mageplaza.com/releases/facebook-plugin/ | ||
| - License agreement: https://www.mageplaza.com/LICENSE.txt | ||
|
|
||
| ## How to install | ||
|
|
||
| ### Install ready-to-paste package (Recommended) | ||
|
|
||
| - Installation guide: https://www.mageplaza.com/install-magento-2-extension/ | ||
|
|
||
| ## How to upgrade | ||
|
|
||
| 1. Backup | ||
|
|
||
| Backup your Magento code, database before upgrading. | ||
|
|
||
| 2. Remove FacebookPlugin folder | ||
|
|
||
| In case of customization, you should backup the customized files and modify in newer version. | ||
| Now you remove `app/code/Mageplaza/FacebookPlugin` folder. In this step, you can copy override FacebookPlugin folder but this may cause of compilation issue. That why you should remove it. | ||
|
|
||
| 3. Upload new version | ||
| Upload this package to Magento root directory | ||
|
|
||
| 4. Run command line: | ||
|
|
||
| ``` | ||
| php bin/magento setup:upgrade | ||
| php bin/magento setup:static-content:deploy | ||
| ``` | ||
|
|
||
|
|
||
| ## FAQs | ||
|
|
||
|
|
||
| #### Q: I got error: `Mageplaza_Core has been already defined` | ||
| A: Read solution: https://github.com/mageplaza/module-core/issues/3 | ||
|
|
||
|
|
||
| #### Q: My site is down | ||
| A: Please follow this guide: https://www.mageplaza.com/blog/magento-site-down.html | ||
|
|
||
|
|
||
| ## Support | ||
|
|
||
| - FAQs: https://www.mageplaza.com/faqs/ | ||
| - https://mageplaza.freshdesk.com/ | ||
| - [email protected] |
Oops, something went wrong.